lint-conventions.sh's 'gate piped into a filter' check covers only skill markdown, not the helper tier #105

New issue

Open

opened 2026-08-25 14:59:40 +00:00 by jbr870 · 0 comments

jbr870 commented

2026-08-25 14:59:40 +00:00

Owner

Spawned from finding F-PO-47-2-11 (in-scope-deferrable) on issue #47 during decision D-PO-47-2-11.

Original scope note: Reviewer suggestion acknowledged but not actioned in this SREQ — see Expert Review > Noted (not actioned). The check that would have caught _gl_api ... | jq '.[0]' in glab-cli/bin/pipeline_status.sh runs over Tier 1 (shell fences in skill markdown) only; the helper tier is exempt from it, which is exactly why that antipattern shipped in a bin/.sh and stayed. This slice fixes the one instance it trips over; extending the lint to bin/.sh so the class cannot recur is larger than this slice and would surface unrelated hits across 117 helper scripts. Proposing defer-to-issue.

Disposition rationale: The lint check that exists to catch a gate piped into a filter runs over Tier 1 only (shell fences in skill markdown), and this feature is the proof that the exemption costs something real: glab-cli/bin/pipeline_status.sh shipped that exact antipattern in a bin/*.sh and the gate never saw it. CLAUDE.md states the rule for the whole suite, so a check that enforces it in one tier and not the other is the gap, not the rule. This slice fixes the single instance it trips over; making the class unrepeatable means extending the population to 117 helper scripts, which will surface unrelated hits that need triage of their own — real work, larger than this slice, and it would derail the feature to absorb. Spawning rather than folding into #67: #67 is also about scripts/lint-conventions.sh but is a different defect (a new check line-regexes instead of reusing the fence tracker), and sharing a file is a weak match — folding would make #67 look like the lint-conventions collector and attract further wrong folds. Resolved autonomously under the operator's explicit instruction in this session to resolve every decision with its recommended option.

This issue was deferred out of the parent feature's scope; it carries no PREQ yet. Run /dev:requirements --issue={new-number} to flesh it out before planning.

Spawned from finding `F-PO-47-2-11` (in-scope-deferrable) on issue #47 during decision D-PO-47-2-11. **Original scope note:** Reviewer suggestion acknowledged but not actioned in this SREQ — see Expert Review > Noted (not actioned). The check that would have caught `_gl_api ... | jq '.[0]'` in glab-cli/bin/pipeline_status.sh runs over Tier 1 (shell fences in skill markdown) only; the helper tier is exempt from it, which is exactly why that antipattern shipped in a bin/*.sh and stayed. This slice fixes the one instance it trips over; extending the lint to bin/*.sh so the class cannot recur is larger than this slice and would surface unrelated hits across 117 helper scripts. Proposing defer-to-issue. **Disposition rationale:** The lint check that exists to catch a gate piped into a filter runs over Tier 1 only (shell fences in skill markdown), and this feature is the proof that the exemption costs something real: glab-cli/bin/pipeline_status.sh shipped that exact antipattern in a bin/*.sh and the gate never saw it. CLAUDE.md states the rule for the whole suite, so a check that enforces it in one tier and not the other is the gap, not the rule. This slice fixes the single instance it trips over; making the class unrepeatable means extending the population to 117 helper scripts, which will surface unrelated hits that need triage of their own — real work, larger than this slice, and it would derail the feature to absorb. Spawning rather than folding into #67: #67 is also about scripts/lint-conventions.sh but is a different defect (a new check line-regexes instead of reusing the fence tracker), and sharing a file is a weak match — folding would make #67 look like the lint-conventions collector and attract further wrong folds. Resolved autonomously under the operator's explicit instruction in this session to resolve every decision with its recommended option. This issue was deferred out of the parent feature's scope; it carries no PREQ yet. Run `/dev:requirements --issue={new-number}` to flesh it out before planning.

jbr870 added the

priority:low

type:tech-debt

phase/backlog

labels

2026-08-25 14:59:40 +00:00

jbr870 referenced this issue

2026-08-25 14:59:41 +00:00

release-pipeline-status.sh --ref returns a stale pipeline — a false green immediately before a production tag #47